[PATCH] Re: Bootstrap broken on powerpc-apple-darwin

[Andrew Pinski <pinskia at physics dot uc dot edu>]

On Mar 15, 2004, at 14:34, Caroline Tice wrote:

> That's gcc 3.5 mainline, just to be clear.
>
> On Mar 15, 2004, at 2:33 PM, Caroline Tice wrote:
>
> > Today I downloaded the latest copy of the gcc3 mainline sources, and 
> > attempted to bootstrap it on
> > darwin.  It fails with the following:
> >
> > ./xgcc -B./ -B/usr/local/powerpc-apple-darwin7.0.0/bin/ -isystem 
> > /usr/local/powerpc-apple-darwin7.0.0/include -isystem 
> > /usr/local/powerpc-apple-darwin7.0.0/sys-include 
> > -L/Volumes/Data/work/gcc5.obj/gcc/../ld -DIN_GCC    -W -Wall 
> > -Wwrite-strings -Wstrict-prototypes -Wmissing-prototypes 
> > -Wold-style-definition  -isystem ./include  -I. -I. -I../../gcc5/gcc 
> > -I../../gcc5/gcc/. -I../../gcc5/gcc/../include   \
> >   -c ../../gcc5/gcc/config/darwin-crt2.c -o crt2.o
> > In file included from ../../gcc5/gcc/tsystem.h:44,
> >                  from ../../gcc5/gcc/config/darwin-crt2.c:35:
> > ./include/stddef.h:151: internal compiler error: Abort trap
> > Please submit a full bug report,
> > with preprocessed source if appropriate.
> > See <URL:http://gcc.gnu.org/bugs.html> for instructions.
> > make[2]: *** [crt2.o] Error 1
> > make[1]: *** [stage1_build] Error 2
> > make: *** [bootstrap] Error 2
> >
> > Could someone please look into this as soon as possible?  Thanks!

The follow patch from Ian gets me further then a failure in libjava 
which is PR 14580.

I applied the follow patch also because it worked for me and RTH oked 
it in IRC.

ChangeLog:

	* config/rs6000/host-darwin.c (darwin_rs6000_gt_pch_use_address):
	Fix the check for abort and only do the mmap if we can.



Index: config/rs6000/host-darwin.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/config/rs6000/host-darwin.c,v
retrieving revision 1.9
diff -u -p -r1.9 host-darwin.c
--- config/rs6000/host-darwin.c	12 Mar 2004 19:45:49 -0000	1.9
+++ config/rs6000/host-darwin.c	15 Mar 2004 22:39:21 -0000
@@ -180,16 +180,19 @@ darwin_rs6000_gt_pch_use_address (void *
   if (munmap (pch_address_space + sz, sizeof (pch_address_space) - sz) 
!= 0)
     fatal_error ("couldn't unmap pch_address_space: %m\n");

-  mmap_result = mmap (addr, sz,
-		      PROT_READ | PROT_WRITE, MAP_PRIVATE | MAP_FIXED,
-		      fd, off);
+  if (ret)
+    {
+      mmap_result = mmap (addr, sz,
+			  PROT_READ | PROT_WRITE, MAP_PRIVATE | MAP_FIXED,
+			  fd, off);

-  /* The file might not be mmap-able.  */
-  ret = mmap_result == (void *) MAP_FAILED;
+      /* The file might not be mmap-able.  */
+      ret = mmap_result == (void *) MAP_FAILED;

-  /* Sanity check for broken MAP_FIXED.  */
-  if (!ret && mmap_result != addr)
-    abort ();
+      /* Sanity check for broken MAP_FIXED.  */
+      if (ret && mmap_result != addr)
+	abort ();
+    }

   return ret;
 }