This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix bitfield-- != 0 transformation in fold-const.c


Hi Roger,

> | > My apologies, I pulled the test case straight from the bugzilla PR
> | > without consideration for "small" targets.  I think its safe to
> | > either just completely remove the ubyte field from the sdata struct,
> | > i.e. for all platforms, or to pad it to a short using "ubyte:8;".
> | > The PR concerns overflow in a single bit field and isn't affected
> | > by this later structure padding.
> | 
> | OK.
> | 
> | > Consider such a patch pre-approved for mainline.  At the risk of
> | > over stepping my authority, I also think its extremely safe to also
> | > fix this testcase on the 3.4 and 3.3 branches.  Mark?  Gaby?
> | 
> | To backport my patch to 3.4 and 3.3, I opened a new PR 14544.
> 
> OK for GCC-3.3.4.

Have you checked in your patch to 3.3 and 3.4?  I just checked 3.3
branch and didn't find gcc.c-torture/execute/20040307-1.c there.  If
you are going to backport, would you mind including my change as well?

Thanks,

Kazu Hirata


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]