This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [tree-ssa] Trivial bugfix and fix optimization/2806


Hi Jeff,

>  >Could we replace 65535 in gcc.dg/tree-ssa/20040305-1.c with 100 or
>  >something?  The reason is because 65535 would cause
>  >
>  >  warning: comparison is always false due to limited range of data type
>  >
>  >on 16-bit targets.  In this case, the purpose of the test is very
>  >clear, so changing magic numbers shouldn't be a problem.  I thought
>  >about adding dg-xfail, dg-options, etc, but they are a bit ugly.
> Yea, go ahead and change it -- it won't affect the test.

Committed the following patch.

Kazu Hirat

2004-03-11  Kazu Hirata  <kazu@cs.umass.edu>

	* gcc.dg/tree-ssa/20040305-1.c: Change a constant to fit in a
	16-bit int.

Index: 20040305-1.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/testsuite/gcc.dg/tree-ssa/Attic/20040305-1.c,v
retrieving revision 1.1.2.1
diff -u -r1.1.2.1 20040305-1.c
--- 20040305-1.c	5 Mar 2004 21:07:20 -0000	1.1.2.1
+++ 20040305-1.c	9 Mar 2004 23:03:34 -0000
@@ -6,7 +6,7 @@
  
 void foo(int edx, int eax)
 {
-  if (eax == 65535)
+  if (eax == 100)
     {
       if (edx == 1)
         {
@@ -14,7 +14,7 @@
           abarney[1] = 6;
         }
     }
-  if (eax == 65535)
+  if (eax == 100)
     {
       if (-- edx == 0)
         afred[0] = 2;


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]