This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Framework support for darwin


On Tuesday, January 27, 2004, at 07:30 PM, Mike Stump wrote:
+ #ifdef TARGET_OPTION_INIT
+   TARGET_OPTION_INIT;
+ #endif

So far as I can tell, the only purpose of this macro is to let you
have some functions in darwin-c.c and some in darwin.c.

Nope. That's not actually why it exists. The reason is much more obscure. fix-header.c wants to include parts of the compiler, but not all the compiler... and this ad-hoc inclusion doesn't work for target hooks and someone else wanted these things to be target hooks and so, we are left with what you see in the patch.


If fix-header wants to include rs6000.o and everything that pulls in, and so on... we could go that direction, but, that path isn't the way I'd want to go, as that'd probably break something, that then people would be unhappy with the patch... and much unhappiness would result.

I've tried to come up with various other ways to do this and all of them failed or were substantially riskier or just plain worse. :-(

Let me know how you'd like proceed.

[ We talked offline about this some more ]


Ok, I've put some of the code back how I had it originally, and it it much nicer... :-( The need for TARGET_OPTION_INIT and the extraneous callback for it thus goes away.

Also, the need for other callback in darwin.c has been eliminated by decoupling TARGET_OPTF from the language independent callbacks, again, reverting the code to be closer to how I had it before.

With some luck, the marry-go-round ride should be nearing completion... :-)

Ok?

Attachment: frameworkk.diffs.txt
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]