This is the mail archive of the
mailing list for the GCC project.
Re: Summary of patches
- From: Zack Weinberg <zack at codesourcery dot com>
- To: Jan Hubicka <jh at suse dot cz>
- Cc: gcc-patches at gcc dot gnu dot org, rth at redhat dot com
- Date: Tue, 02 Mar 2004 03:02:42 -0800
- Subject: Re: Summary of patches
- References: <20040301125246.GJ16281@kam.mff.cuni.cz>
Jan Hubicka <firstname.lastname@example.org> writes:
> here is list of patches from last two months that still should be
> - this is only libjava part, I will send the rest as followup
Looks fine but I would rather a libjava person reviewed it.
> - trivial, move unnecesary GGC allocation to malloc
> - avoids expensive indexing of memories in the case we won't use it
> - fix potential code quality problem brought by my earlier patch.
> - trivial cleanup
These are OK.
This is also OK; if you feel motivated you might look at mashing the
loops together so we only scan the insn chain once. (I do not know if
this is possible.)
> - loglinks in allocpools
Is INSN_UID reset between functions? If not, that array is going to
get huge and I don't think this is a good idea.
> - Varrays allocated by xmalloc
The ggc-none implementation of ggc_free is OK; please commit that
I do not like the part where you change every last instance of
VARRAY_*_INIT. I would prefer if there were some automatic way to
determine whether or not a varray needed to be allocated via
ggc_alloc. Better still, figure out some way whereby varrays can be
marked and swept without ever using ggc_alloc (which is not suited to
resizable data structures) for them.
> Per call statistics:
> (there is only one conflict if the patch is applied to tree-ssa branch so it
> should not bring any merge problems to Diego)
This is OK provided that you submit a follow-up patch which adds
--enable-statistics to configure.
> [tree-ssa/tree-profiling] Fix BB merging ICE
> More of the work to get SSE initializers sane.
> [tree-ssa] Elliminate addressof
> Make DOM1 to cope with pure functions and allows libcall notes
> for function calls to be elliminated.
I am not qualified to review these.