This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch, rfa] charset testsuite patches, take 2


On Fri, 2004-02-27 at 20:56, David Edelsohn wrote:
> 	* lib/target-supports.exp (check-iconv-available): New function.
> 
> This new dg infrastructure is broken on targets that require linking with
> libiconv, such as AIX.  The gcc and libstdc++-v3 builds explicitly test
> for libiconv.
> 
> 	Currently tmp.x fails to link and the test fails with errors.

Can you give this patch a try please?

-eric

-- 
Eric Christopher <echristo@redhat.com>
Index: target-supports.exp
===================================================================
RCS file: /cvs/gcc/gcc/gcc/testsuite/lib/target-supports.exp,v
retrieving revision 1.13
diff -u -p -w -r1.13 target-supports.exp
--- target-supports.exp	27 Feb 2004 02:01:10 -0000	1.13
+++ target-supports.exp	29 Feb 2004 07:13:52 -0000
@@ -231,6 +231,9 @@ proc check_iconv_available { test_what }
 
     set lines [${tool}_target_compile "tmp.c" "tmp.x" executable ""]
 
+    if [string match "" $lines] then {
+	# No error messages, everything is OK.
+
     set result [${tool}_load "./tmp.x" "" ""]
     set status [lindex $result 0];
 
@@ -238,6 +241,7 @@ proc check_iconv_available { test_what }
 
     if { $status == "pass" } then {
 	return 1
+	}
     }
 
     return 0

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]