This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] MIPS: Two classes associated with the "e" constraint


"Maciej W. Rozycki" <macro@ds2.pg.gda.pl> writes:
>  I've noticed the "e" constraint is bound to two register classes,
> M16_NA_REGS and LEA_REGS, with obviously only one being active.  Here's an
> obvious fix, allocating a new constraint for LEA_REGS, the newer of the
> two classes.  But AFAICT "e" isn't used to refer to M16_NA_REGS anymore, 
> so perhaps this meaning can simply be removed.

Yes:

  mips_char_to_class['e'] = M16_NA_REGS;

should just be removed.  Like you say, it's not used by any of the
.md patterns.  Nor is it documented as a MIPS-specific constraint,
so I don't see any need to keep it for inline asm.

I remember checking that "e" wasn't needed before remapping it to
LEA_REGS.  ("e" for effective address, of course.)  I was supposed
to get rid of the line above at the same time. but obviously I forgot.

Richard


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]