This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [committed] allow assert in inner class


>>>>> "Eric" == Eric Blake <ebb9@byu.net> writes:

Eric> Actually, for inner classes, they should be checking the assertion
Eric> level of the enclosing class.  There is a whole series of tests for
Eric> correct semantics in jacks.

Yeah.  Folks, please run Jacks when you make gcj front-end changes.
I've seen a bunch of FAILs crop up; for Jacks we maintain an xfail
file that, in theory, encodes exactly what we know works and does not
work.  The appearance of a new FAIL means that someone has made front
end changes without checking for regressions.

Eric> And does your patch work for asserts inside an inner class of an
Eric> interface, since interfaces can't have a static helper?

Does jikes generate a new static package-private inner class of the
interface in this situation?  Ugh.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]