Re: PATCH for java.nio FileChannel and MappedByteBuffer

[Ranjit Mathew <rmathew at hotmail dot com>]

Per Bothner wrote:
> [This does seem to be turning into a "bikeshed discussion" ...]

:-)

Just in case someone didn't get this:

    http://www.unixguide.net/freebsd/faq/16.19.shtml

FWIW, I feel all dirty seeing a non-header file
being #include-d, but do not have any more concrete
arguments to add to this discussion than what has
been put forth by Tom, Mohan and Michael.

BTW, though it does not seem to be mandated (or frowned
upon) by the GNU coding standards document, stuff
within #ifdef conditionals looks much better (IMHO)
when it's indented like stuff within "regular" if
statements like so:

  #ifdef FOO
    #include <snafu.h>
  #endif /* FOO */

or perhaps like so for some older pre-processors:

  #ifdef FOO
  #  include <snafu.h>
  #endif /* FOO */

At least the Boehm-GC sources follow this
convention and IMHO that makes the code look
much cleaner.

My 2p.

Ranjit.

-- 
Ranjit Mathew          Email: rmathew AT hotmail DOT com

Bangalore, INDIA.      Web: http://ranjitmathew.tripod.com/