This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
[committed] some minor comment improvements to gcc/java
- From: Per Bothner <per at bothner dot com>
- To: gcc-patches at gcc dot gnu dot org
- Date: Wed, 25 Feb 2004 21:03:06 -0800
- Subject: [committed] some minor comment improvements to gcc/java
The phrase "non-null" is appropriate for a pointer-valued
expression, but misleading for a true boolean expression.
For GET_CPC, DECL_TYPE should be TYPE_DECL, and while fixing
this I improved the grammar.
Checked into mainline.
--
--Per Bothner
per@bothner.com http://per.bothner.com/
Index: java-tree.h
===================================================================
RCS file: /cvs/gcc/gcc/gcc/java/java-tree.h,v
retrieving revision 1.194
diff -u -r1.194 java-tree.h
--- java-tree.h 16 Jan 2004 17:11:08 -0000 1.194
+++ java-tree.h 26 Feb 2004 04:40:22 -0000
@@ -1615,12 +1615,12 @@
inner class access function. */
#define OUTER_FIELD_ACCESS_IDENTIFIER_P(NODE) TREE_LANG_FLAG_6(NODE)
-/* Non null if NODE belongs to an inner class TYPE_DECL node.
+/* True if NODE belongs to an inner class TYPE_DECL node.
Verifies that NODE as the attributes of a decl. */
#define INNER_CLASS_DECL_P(NODE) (TYPE_NAME (TREE_TYPE (NODE)) == NODE \
&& DECL_CONTEXT (NODE))
-/* Non null if NODE is an top level class TYPE_DECL node: NODE isn't
+/* True if NODE is an top level class TYPE_DECL node: NODE isn't
an inner class or NODE is a static class. */
#define TOPLEVEL_CLASS_DECL_P(NODE) (!INNER_CLASS_DECL_P (NODE) \
|| CLASS_STATIC (NODE))
@@ -1630,7 +1630,7 @@
#define PURE_INNER_CLASS_DECL_P(NODE) \
(INNER_CLASS_DECL_P (NODE) && !CLASS_STATIC (NODE))
-/* Non null if NODE belongs to an inner class RECORD_TYPE node. Checks
+/* True if NODE belongs to an inner class RECORD_TYPE node. Checks
that TYPE_NAME bears a decl. An array type wouldn't. */
#define INNER_CLASS_TYPE_P(NODE) (TREE_CODE (TYPE_NAME (NODE)) == TYPE_DECL \
&& DECL_CONTEXT (TYPE_NAME (NODE)))
@@ -1643,7 +1643,7 @@
#define PURE_INNER_CLASS_TYPE_P(NODE) \
(INNER_CLASS_TYPE_P (NODE) && !CLASS_STATIC (TYPE_NAME (NODE)))
-/* Non null if NODE (a TYPE_DECL or a RECORD_TYPE) is an inner class. */
+/* True if NODE (a TYPE_DECL or a RECORD_TYPE) is an inner class. */
#define INNER_CLASS_P(NODE) (TREE_CODE (NODE) == TYPE_DECL ? \
INNER_CLASS_DECL_P (NODE) : \
(TREE_CODE (NODE) == RECORD_TYPE ? \
Index: parse.h
===================================================================
RCS file: /cvs/gcc/gcc/gcc/java/parse.h,v
retrieving revision 1.93
diff -u -r1.93 parse.h
--- parse.h 9 Oct 2003 05:44:57 -0000 1.93
+++ parse.h 26 Feb 2004 04:40:23 -0000
@@ -807,7 +807,7 @@
an inner class is pushed. After, use FIXME. */
#define CPC_INNER_P() GET_CPC_LIST ()
-/* Get the currently parsed class DECL_TYPE node. */
+/* The TYPE_DECL node of the class currently being parsed. */
#define GET_CPC() TREE_VALUE (GET_CPC_LIST ())
/* Get the currently parsed class unqualified IDENTIFIER_NODE. */