Re: [Darwin] Patch: new compiler option, -mmacosx-<version>

[Stan Shebs <shebs at apple dot com>]

Matt Austern wrote:

> Pretty simple and self-explanatory, so I won't say anything more than 
> what's in the patch itself.  OK to commit to mainline?
I take you didn't like my suggestion to compute a number instead of
using table lookup, or Zem's idea of using -mmacosx=xxx ? Using the '='
form would be more consistent with recent multi-value options like
-mcpu and -mtune, although I don't know if there's an objective reason
to choose = over -.

> +       if (v->vers_str)
> +     macosx_version_min_required = v->vers_num;

This will be silent if the version number is not recognized, right?
I think if you're going to restrict values to the fixed table, there
ought to be at least be a warning that the specified number (or other
string) is perhaps mistaken. (Hey, maybe you could add "jaguar",
"panther", etc too.)

> + #define SUBTARGET_OVERRIDE_OPTIONS                      \
> + do {                                    \
> +   
> darwin_parse_macosx_version_name();                                   \
> + }while(0)

Missing those all-important spaces - three of them!! :-)

> +   
> darwin_parse_macosx_version_name();                                   \

And here.

Stan