This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Eliminate libiberty warnings
- From: Matt Kraai <kraai at ftbfs dot org>
- To: gcc-patches at gcc dot gnu dot org
- Date: Mon, 16 Feb 2004 09:38:43 -0800
- Subject: Eliminate libiberty warnings
Howdy,
libiberty's regex.c produces the following warnings:
../../baseline.gcc/libiberty/regex.c: In function `xregcomp':
../../baseline.gcc/libiberty/regex.c:8043: warning: signed and unsigned type in conditional expression
../../baseline.gcc/libiberty/regex.c: In function `xregerror':
../../baseline.gcc/libiberty/regex.c:8178: warning: unused parameter `preg'
The following patch eliminates them. It was bootstrapped and
regression tested on powerpc-unknown-linux-gnu.
OK to commit?
--
Matt Kraai kraai@ftbfs.org http://ftbfs.org/
* regex.c: Include <ansidecl.h>.
(regcomp): Cast i to int.
(regerror): Add ATTRIBUTE_UNUSED to parameter preg.
Index: libiberty/regex.c
===================================================================
RCS file: /cvs/gcc/gcc/libiberty/regex.c,v
retrieving revision 1.14
diff -c -3 -p -r1.14 regex.c
*** libiberty/regex.c 15 Apr 2003 14:24:26 -0000 1.14
--- libiberty/regex.c 15 Feb 2004 17:31:58 -0000
***************
*** 36,41 ****
--- 36,43 ----
# include <config.h>
#endif
+ #include <ansidecl.h>
+
#ifndef PARAMS
# if defined __GNUC__ || (defined __STDC__ && __STDC__)
# define PARAMS(args) args
*************** regcomp (preg, pattern, cflags)
*** 8040,8046 ****
/* Map uppercase characters to corresponding lowercase ones. */
for (i = 0; i < CHAR_SET_SIZE; i++)
! preg->translate[i] = ISUPPER (i) ? TOLOWER (i) : i;
}
else
preg->translate = NULL;
--- 8042,8048 ----
/* Map uppercase characters to corresponding lowercase ones. */
for (i = 0; i < CHAR_SET_SIZE; i++)
! preg->translate[i] = ISUPPER (i) ? TOLOWER (i) : (int) i;
}
else
preg->translate = NULL;
*************** weak_alias (__regexec, regexec)
*** 8175,8181 ****
size_t
regerror (errcode, preg, errbuf, errbuf_size)
int errcode;
! const regex_t *preg;
char *errbuf;
size_t errbuf_size;
{
--- 8177,8183 ----
size_t
regerror (errcode, preg, errbuf, errbuf_size)
int errcode;
! const regex_t *preg ATTRIBUTE_UNUSED;
char *errbuf;
size_t errbuf_size;
{