This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch, toplevel] --enable-multilib*S* is an easy typo to recognize...
On Feb 14, 2004, Phil Edwards <phil@jaj.com> wrote:
> But failing with an error works just as well.
It's actually just as bad :-)
Consider that we drop into the top level a new package that takes
--enable-multilibs as an argument?
Why should the top level configure prevent this package from having
its own option used?
--enable/with arguments that a package doesn't understand are supposed
to be ignored. They don't have to be silently ignored, but you
shouldn't error out because of them. This is what your patch does.
An early warning with a 10-seconds pause would probably be
fine. Bailing out isn't.
Patch hesitantly approved after the error is turned into a warning,
and a sleep is added if you like.
--
Alexandre Oliva Enjoy Guarana', see http://www.ic.unicamp.br/~oliva/
Happy GNU Year! oliva@{lsd.ic.unicamp.br, gnu.org}
Red Hat GCC Developer aoliva@{redhat.com, gcc.gnu.org}
Free Software Evangelist Professional serial bug killer