Re: Unreviewed patch: PATCH: [darwin] Adding branch prediction bits for bdxx instructions

[Caroline Tice <ctice at apple dot com>]

You are right, I originally mis-read the comment and used the wrong 
value.  Below is a corrected
version of the patch (the only change is the value assigned to 
MASK_NO_BRANCH_PREDICTIONS).

Is this okay to commit?

-- Caroline Tice
ctice@apple.com

On Feb 10, 2004, at 4:06 PM, Andrew Pinski wrote:

> On Feb 10, 2004, at 15:55, Alan Modra wrote:
>
> > On Tue, Feb 10, 2004 at 11:07:03AM -0800, Caroline Tice wrote:
> > > + /* Disable branch predictions */
> > > + #define MASK_NO_BRANCH_PREDICTIONS 0x00100000
> >
> > Clashes with linux64.h:MASK_PROFILE_KERNEL.
>
>
> The last free bits are documented in rs6000.h:
> /* The only remaining free bits are 0x00600000.  linux64.h uses
>    0x00100000, and sysv4.h uses 0x00800000 -> 0x40000000.
>    0x80000000 is not available because target_flags is signed.  */
>
>
> So use one of those free bits.
>
> Thanks,
> Andrew Pinski