This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] Change the default of TARGET_STRUCT_VALUE_RTX.
- From: "Zack Weinberg" <zack at codesourcery dot com>
- To: Kazu Hirata <kazu at cs dot umass dot edu>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Sun, 08 Feb 2004 10:54:14 -0800
- Subject: Re: [patch] Change the default of TARGET_STRUCT_VALUE_RTX.
- References: <20040208.125633.95429912.kazu@cs.umass.edu>
Kazu Hirata <kazu@cs.umass.edu> writes:
> Hi,
>
> Attached is a patch to change the default of TARGET_STRUCT_VALUE_RTX.
>
> Currently, the default of TARGET_STRUCT_VALUE_RTX is to call abort(),
> which is not very useful, and indeed no port uses the default.
>
> The patch creates a resonable default value for
> TARGET_STRUCT_VALUE_RTX, which is to put the pointer to a structure as
> the first invisible argument.
>
> Bootstrapped on i686-pc-linux-gnu. OK to apply?
Please update the documentation (if any); also
> -#undef TARGET_STRUCT_VALUE_RTX
> -#define TARGET_STRUCT_VALUE_RTX vax_struct_value_rtx
that's not hook_rtx_tree_int_null. vax_struct_value_rtx does
return gen_rtx_REG (Pmode, VAX_STRUCT_VALUE_REGNUM);
which I do not think is the same as the default; but I could be
wrong. Please either leave the VAX port alone, or else verify that
this has the same effect as the default, and remove the definition of
vax_struct_value_rtx too.
zw