Re: [PATCH][gfortran][PR 13909] f77 style logical*1 variables unusable

[Paul Brook <paul at codesourcery dot com>]

On Thursday 05 February 2004 4:00 am, bud davis wrote:
> Below is a patch for your consideration to fix PR 13909.  It corrects
> the problem reported in the PR and introduces no new testsuite
> regressions.
>
> Tested on i686-pc-linux-gnu.
>
>
> Changelog entry:
>
>          B.Davis  bdavis9659@comcast.net
>
>          PR gfortran/13909
>          * intrinsic.c (add_conversions) changed logical to use logical
> conversion instead of real.
>          * trans-types.c (gfc_get_logical_type) implemented logical*1
> and logical*2.

Applied, thanks. However see below.

> As far as testsuite is concerned, may I suggest the following test be
> added to gcc/testsuite/g77.f-torture/compile.  My reasoning is thus;
> gfortran will compile g77 code, so eventually it will inherit the f77
> testsuite.
>
>        LOGICAL*1 A
>        A = .TRUE.
>        END
>
>
> I propose the below patch is a "small change" and can be accepted
> without copyright assignment.

This change in itself may be a small change, however I notice you have also 
submitted several other patches to g77 in the past. The combined size of 
these, plus the associated testcases probably are a legally significant 
change. 

So, you really should get yourself a copyright assignment.
See http://www.gnu.org/prep/maintain_6.html#SEC6.

I'll accept this change on the basis that g77 and gfortran are nominally 
seperate projects. However I'm reluctant to accept further patches without a 
copyright assignment. I realise this is a pain, but unless someone with 
greater autority says otherwise we must adhere to these rules.

Paul