This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [c++ patch] avoid inlining twice


> Jan Hubicka wrote:
> 
> >Hi,
> >I've sent this few times already, but this time I really need it.
> >Inlining is currently performced twice - once in optimize_function in
> >C++ frontend, later in cgraph_optimize_function in the backend.  This
> >kills the first.  It is needed for my cgraph code changes where inlining
> >must happent after original body has been saved.
> >
> >Bootstrapped/regtested i686-pc-gnu-linux, OK?
> > 
> >
> What if !flag_unit_at_a_time?

Even in non-unit-at-a-time, the cgraphunit will do the inlining, there
is no difference from frontend side anymore.
> 
> (I'd actually like to see you get rid of that flag; it would be better 
> if we were just always unit-at-a-time.)

Me too.  The compatiblity issues are getting solved quite happily.
Linux kernel is now mostly safe, so remaining known blockers are one
file in glibc and crtbegin.c in GCC.  I think we can discuss doing that
for 3.5 and perhaps we can even add a comment to current .texi manual
that the flag is there just to help update existing codebases (I already
mentioned the possibility of dropping it in changes.html)

Honza
> 
> -- 
> Mark Mitchell
> CodeSourcery, LLC
> (916) 791-8304
> mark@codesourcery.com
> 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]