This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] genrecog.c: Simplify comparisons against smallconstants in insn-recog.c.

From: Kazu Hirata <kazu at cs dot umass dot edu>
To: rth at redhat dot com
Cc: roger at eyesopen dot com, gcc-patches at gcc dot gnu dot org
Date: Fri, 30 Jan 2004 19:56:04 -0500 (EST)
Subject: Re: [patch] genrecog.c: Simplify comparisons against smallconstants in insn-recog.c.
References: <20040130011912.GA11790@redhat.com><Pine.LNX.4.44.0401300611150.32111-100000@www.eyesopen.com><20040130224424.GC17578@redhat.com>

Hi Richard,

> > Isn't this simply an extension of the cleanup
> > "GET_CODE (x) == CONST_INT && XWINT (x, 0) == 0" to "x == const0_rtx"?
> 
> Yes, it is.  I suppose for that, we might as well be consistent.

What do you mean by consistent?  Apply my patch?  Or don't clean up
"GET_CODE (x) == CONST_INT && INTVAL (x) == 0" any more?

Kazu Hirata

Follow-Ups:
- Re: [patch] genrecog.c: Simplify comparisons against small constants in insn-recog.c.
  - From: Richard Henderson

References:
- Re: [patch] genrecog.c: Simplify comparisons against small constants in insn-recog.c.
  - From: Richard Henderson
- Re: [patch] genrecog.c: Simplify comparisons against small constantsin insn-recog.c.
  - From: Roger Sayle
- Re: [patch] genrecog.c: Simplify comparisons against small constants in insn-recog.c.
  - From: Richard Henderson

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]