This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Fix IA-64 bootstrap failure

On Fri, 2004-01-30 at 05:49, Jan Hubicka wrote:
> 	* alias.c (find_base_term, get_addr):  Do not dereference NULL
> 	pointer when all VALUE's locations has been invalidated.
> 	(rtx_equal_for_memref_p): Simplify.

OK.

I'll make the same suggestion as Jakub, rtx_equal_for_mem_p should have
a commented case for VALUE that returns zero.  I was more concerned
about commenting why we removed the checks for CSELIB_VAL_PTR here, but
Jakub also makes a good point that this helps compile time performance. 
The CONST_INT/CONST_DOUBLE case already has the comment we need, so just
add VALUE to it.
-- 
Jim Wilson, GNU Tools Support, http://www.SpecifixInc.com
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]