This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [v3] PR 11584

From: Martin Sebor <sebor at roguewave dot com>
To: Jerry Quinn <jlquinn at optonline dot net>
Cc: libstdc++ at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
Date: Tue, 27 Jan 2004 10:39:17 -0700
Subject: Re: [v3] PR 11584
References: <E1AlJ0X-0007BX-00@smaug>

Jerry Quinn wrote:

This patch fixes PR 11584.  The catch here is the standard is somewhat
underspecified.  The testcase checks iword(100), because in our
implementation, iword(1) will always succeed.  The way I read the
standard, this is ok, since even though new is overridden, the
allocation of space for iword(1) didn't fail.

Martin, does this solution make sense to you?


I think the solution is fine. My only suggestion would be to also
guard against negative indices in the two inline member functions
(it seems that a negative index might cause trouble when using it
to dereference an _M_words array element).

Martin

References:
- [v3] PR 11584
  - From: Jerry Quinn

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]