This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: 3.4 bugs with unreviewed patches.


On 21 Jan 2004, Falk Hueffner wrote:
> Roger Sayle <roger@eyesopen.com> writes:
>
> > > PR 12898 - Tru64 UNIX bootstrap failure -
> > > <http://gcc.gnu.org/ml/gcc-patches/2003-12/msg00460.html>
> >
> > I'm sure I mentioned to Falk that if he reposted this with a
> > ChangeLog entry and mentioned where he'd tested it, I'd approve
> > it.  Ok for mainline.  Again, if it survives a week, Ok for 3.4.
>
> Thanks. Do you want me to check in the test case too?
> (http://gcc.gnu.org/ml/gcc-patches/2003-12/msg01134.html) Since this
> is reload related, it will probably stop triggering the problem the
> next time somebody sneezes, so I'm not sure it makes sense.

Yes please.  Its far better to have an extra testcase that might not
trigger the original problem, than to accidentally reintroduce a bug
that's previously been analysed and fixed.  Anybody changing reload
relies heavily on the testsuite's coverage of difficult cases, especially
for this kind of heisenbug that depends upon the phase of the moon.

Many thanks,

Roger
--


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]