This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] [Bug bootstrap/12179] [3.4/3.5 Regression] --enable-version-specific-runtime-libs put files in the wrong place


This is *not* OK for all the Ada changes.
Only Makefile.adalib may be OK, although a more careful (rather
than mechanical) review is needed. The other changes are not appropriate:

- the doc change is useless, since the gcc version is kept at 2.8.1
  so the example is no longer meaningful. since this is only an example,
  I'd not change it.

- the gnatlink and osint.adb changes are wrong: the current code is designed
  to handle several gcc versions (from 2.8.1 up to 3.5), so your change
  is unneeded and confusing (apart from being wrong if you look at it in
  details). No changes are needed there.

- the osint.ads change is not complete. I'll take care of
  changing this file appropriately so no need to worry about it.

To summarize, do not make changes in the Ada directory for this issue.
I'll take care of updating osint.ads and Makefile.adalib appropriately.

Arno


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]