This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] regrename.c: Fix a warning.

From: Richard Henderson <rth at redhat dot com>
To: Richard dot Earnshaw at arm dot com
Cc: Kazu Hirata <kazu at cs dot umass dot edu>, gcc-patches at gcc dot gnu dot org, rearnsha at arm dot com
Date: Thu, 15 Jan 2004 01:47:30 -0800
Subject: Re: [patch] regrename.c: Fix a warning.
References: <20040115070404.GD16623@redhat.com> <200401150928.i0F9SHo07508@pc960.cambridge.arm.com>

On Thu, Jan 15, 2004 at 09:28:16AM +0000, Richard Earnshaw wrote:
> Yep.  I can't say I much like that idiom.  I'd much rather see
> 
> 	if ((var = val) != 0)
> 
> making the comparison explicit.
> 
> But that's personal preference.

Personally, I agree.  But what's done is done.


r~

References:
- Re: [patch] regrename.c: Fix a warning.
  - From: Richard Henderson
- Re: [patch] regrename.c: Fix a warning.
  - From: Richard Earnshaw

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]