This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Updated version of -Winline warnings patch

From: Gábor Lóki <loki at inf dot u-szeged dot hu>
To: Jan Hubicka <jh at suse dot cz>
Cc: gcc-patches at gcc dot gnu dot org
Date: Fri, 09 Jan 2004 09:40:29 +0100
Subject: Re: Updated version of -Winline warnings patch
References: <3FFD5E2F.6000200@inf.u-szeged.hu> <20040108145854.GC6509@kam.mff.cuni.cz>

Jan Hubicka wrote:

As you see below, the "node1->callers->inline_call" condition was
converted into "node1->callers->inline_failed", not into a
"!node1->callers->inline_failed".

Is this intentional or is it a typo?!

It is typo. Thanks for noticing it!  (perhaps adding some function
abstraction here would help)
I tested it on Gerald's testcase and obviously it has no sites to be
inlined once.  Does fixing it fix the code size growth?


Yes. Thanks!
It'll show up in CSiBE tomorrow.

Regards,
  Gábor Lóki

References:
- Re: Updated version of -Winline warnings patch
  - From: Gábor Lóki
- Re: Updated version of -Winline warnings patch
  - From: Jan Hubicka

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]