This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Updated version of -Winline warnings patch
- From: Gábor Lóki <loki at inf dot u-szeged dot hu>
- To: gcc-patches at gcc dot gnu dot org
- Cc: jh at suse dot cz
- Date: Thu, 08 Jan 2004 14:42:07 +0100
- Subject: Re: Updated version of -Winline warnings patch
I've managed to forget to commit the patch for proper -Winline
warning. Since
this is a regression relative to older GCC versions that used to
produce
usefull messages, I've updated the patch and will commit it tomorrow.
I will
also prepare tree-ssa branch version.
Bootstrapped/regtested i686-pc-gnu-linux
According to the results measured with CSiBE this patch is responsible
for about 0.5% code size increase for all targets but i386.
After I looked through the patch I had found the problematic part.
As you see below, the "node1->callers->inline_call" condition was
converted into "node1->callers->inline_failed", not into a
"!node1->callers->inline_failed".
Is this intentional or is it a typo?!
Regards,
Gábor Lóki
*************** cgraph_decide_inlining (void)
*** 1168,1179 ****
/* Verify that we won't duplicate the caller. */
for (node1 = node->callers->caller;
! node1->callers && node1->callers->inline_call
&& ok; node1 = node1->callers->caller)
if (node1->callers->next_caller || node1->needed)
ok = false;
if (ok)
{
if (cgraph_dump_file)
fprintf (cgraph_dump_file,
"\nConsidering %s %i insns.\n"
--- 1208,1220 ----
/* Verify that we won't duplicate the caller. */
for (node1 = node->callers->caller;
! node1->callers && node1->callers->inline_failed
&& ok; node1 = node1->callers->caller)
if (node1->callers->next_caller || node1->needed)
ok = false;
if (ok)
{
+ const char *dummy_reason;
if (cgraph_dump_file)
fprintf (cgraph_dump_file,
"\nConsidering %s %i insns.\n"