Re: [libgfortran] Change complex type letter to 'z'

[Feng Wang <wf_cs at yahoo dot com>]

 --- Paul Brook <paul@codesourcery.com> 的正文：> > > > >   The front end of
fortran uses 'z' as the complex type letter. But
> > > > > libgfortran
> > > > > uses 'c'and this will cause link error. This patch fixes this.
> > > > >   The libgfortran ChangeLog entry:
> > > > > 2003-12-16  Feng Wang  <fengwang@nudt.edu.cn>
> > >
> > > Your patch, IMHO, is perfectly backwards.  Complex is
> > > spelled with a "c" not a "z".
> >
> >   gfc_type_letter() in intrinsic.c returnes 'z' to BT_COMPLEX. This is used
> > by iresolve functions to form the name of functions to call the library
> > function. Howerver the libgfortran use 'c' as the complex type letter. This
> > cause to link error.
> >   Does your gfortran pass the test program?
> 
> I think the point is that gfc_type_letter should be changed to 'c', not 
> changing libgfortran to 'z'. I'm inclined to agree.
    I wanted to do this originally. But what about BT_CHARACTER? Now it returns
'c'. Maybe BT_CHARACTER should also be changed to 's' or other letter. I
changed the BT_CHARACTER to 's' and passed the testsuits. But I am not sure
that the change will not cause other potential errors.
   If these changes(BT_CHARACTER returns 's', BT_COMPLEX returns 'c') can be
accepted to us, I can take another patch.
  
> 
> Paul
>  

__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com