This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [tree-ssa] Fix bootstrap failure caused by tree-ssa-loop.c


> In message <20031211210135.GC27614@kam.mff.cuni.cz>, Jan Hubicka writes:
>  >That breaks not only by Zdenek's code.  Any edge splitting or such would
>  >break it.  How it is supposed to work?
> Which is why PRE (for example) rebuilds the dominator tree.
> 
> I don't think it's particularly interesting to describe how it is supposed
> to work since I don't think the current implementation is desirable long
> term since it's intimately ties to block indices.  That's a long term
> recipe for disaster.

Yes, Zdenek already re-implemented it and it seems to me that he did
very good job about it.
I was quite surprised by this as for instance tail call probably got
this wrong while splitting the entry block to produce loopback edges.
I've completely missed this part of interface.
We really should think on making some kind of sanity checkers for such a
non-obvious parts of interaces when we don't have any documentation...

Honza
> 
> 
> jeff


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]