This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] Fix warnings related to GET_MODE_{BITSIZE|SIZE}.
Hi Kaveh,
> > Attached is a patch to fix warnings related to
> > GET_MODE_{BITSIZE|SIZE}.
> >
> > Until now, GET_MODE_{BITSIZE|SIZE} were of unsigned short to suppress
> > warnings. The most natural type would probably be unsigned int, and
> > we should fix resulting warnings.
> >
> > Tested on i686-pc-linux-gnu. OK to apply?
>
> IIRC, this area is delicate and contained numerous port specific
> warnings too. If you're going to change it, I suggest testing the
> patch in cross-compiler configurations to all the primary (and maybe
> secondary) evaluation platforms to make sure you don't introduce
> -Werror bootstrap failures for them.
OK.
> E.g. I notice that you touch i386.md, but no other config files. This
> tells me your patch will probably break everyone else.
In fact, I already know that h8300 needs some follow up. :-(
> Please consider not changing GET_MODE_{BITSIZE|SIZE} and just fix the
> warning(s) you get it that situation. (You don't mention on what
> platform or what warning(s) you currently get that inspired your
> patch.)
OK. Two unsigned/signed comparison warnings from emit-rtl.c seem to
occur on all of five or six random targets that I tested.
Kazu Hirata