This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] PR c/13134


On Thu, Dec 04, 2003 at 01:57:15PM -0800, Matt Austern wrote:
> +       /* If either declaration has a nondefault visibility, use it.
> +          (Should we give an error if we have two different nondefault
> +          visibilities?) */

We should do something, yes.

> + __attribute__((visibility ("hidden")))
> + void foo() { }
...
> + __attribute__((visibility ("hidden")))
> + int xyzzy = 5;

Misplaced attributes.  They should go immediately before the name.

> + /* { dg-do compile { target *86-pc-linux* } } */

Please do something like check_weak_available in target-supports.exp.
I'm comfortable with starting with all elf, and let folks add exceptions
as necessary.  I have little sympathy with using old binutils on linux.


r~


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]