This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] PR c/13134
- From: Richard Henderson <rth at redhat dot com>
- To: Matt Austern <austern at apple dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Thu, 4 Dec 2003 17:17:48 -0800
- Subject: Re: [PATCH] PR c/13134
- References: <D265DB6C-26A4-11D8-BF21-000393B2ABA2@apple.com>
On Thu, Dec 04, 2003 at 01:57:15PM -0800, Matt Austern wrote:
> + /* If either declaration has a nondefault visibility, use it.
> + (Should we give an error if we have two different nondefault
> + visibilities?) */
We should do something, yes.
> + __attribute__((visibility ("hidden")))
> + void foo() { }
...
> + __attribute__((visibility ("hidden")))
> + int xyzzy = 5;
Misplaced attributes. They should go immediately before the name.
> + /* { dg-do compile { target *86-pc-linux* } } */
Please do something like check_weak_available in target-supports.exp.
I'm comfortable with starting with all elf, and let folks add exceptions
as necessary. I have little sympathy with using old binutils on linux.
r~