Re: [PATCH] libffi: x86 win32 fix

[Andreas Tobler <toa at pop dot agri dot ch>]

Hi Yuji,


Hosaka Yuji wrote:

> Here is a patch for libffi.
> On x86 win32 platform, libffi testsuite fails some test cases.
> There is three causes;
>
>  - wrong structure alignment size of double and 64-bits integer.
>
>  - when returning structure and size of structure is 1, 2, 4, or
>    8-bytes, return value is pass by register instead of hidden first
>    argument for pointer to return value storage.
>
>  - test case libffi.call/many_win32.c couldn't compile.
>    It needs to include <float.h> but missing, and variable `ul' is
>    undefined.

Thank you! Never found a person who actually tested these tests.

> Attached file libffi-win32.patch is a patch to fix these problems.
> struct_align.tar.gz is some test cases to check structure alignment.

I'll take care on the test cases and add them to the suite.
THANKS!

> I tested this patch on i686-pc-cygwin and i686-pc-linux-gnu

For the real fixes I hope a responsible will speak up.

Regards,

Andreas