This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Unreviewed patch
"Zack Weinberg" <zack@codesourcery.com> writes:
| Ulrich Weigand <weigand@i1.informatik.uni-erlangen.de> writes:
| ...
| > As to why this is the right fix, if you look at all the other
| > places in unroll.c (or loop.c) where the BIV initial value
| > is used in some computation involving a GIV, it is *always*
| > passed through extend_value_for_giv. This was initially
| > introduced by rth's patch
| > http://gcc.gnu.org/ml/gcc-patches/2000-09/msg00257.html
| >
| > It looks like this was just forgotten at that one location,
| > and simply unnoticed until now because it's hard to trigger.
|
| Okay, in that case I approve the patch for mainline, and you should
| inquire of Gaby whether it's okay for 3.3 branch.
Assuming proper testing reveals no regression, it is OK.
Thanks for reviewing.
-- Gaby