This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Unreviewed patch
- From: "Zack Weinberg" <zack at codesourcery dot com>
- To: Ulrich Weigand <weigand at i1 dot informatik dot uni-erlangen dot de>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Mon, 01 Dec 2003 13:30:34 -0800
- Subject: Re: Unreviewed patch
- References: <200312012027.VAA24818@faui1d.informatik.uni-erlangen.de>
Ulrich Weigand <weigand@i1.informatik.uni-erlangen.de> writes:
...
> As to why this is the right fix, if you look at all the other
> places in unroll.c (or loop.c) where the BIV initial value
> is used in some computation involving a GIV, it is *always*
> passed through extend_value_for_giv. This was initially
> introduced by rth's patch
> http://gcc.gnu.org/ml/gcc-patches/2000-09/msg00257.html
>
> It looks like this was just forgotten at that one location,
> and simply unnoticed until now because it's hard to trigger.
Okay, in that case I approve the patch for mainline, and you should
inquire of Gaby whether it's okay for 3.3 branch.
zw