This is the mail archive of the
mailing list for the GCC project.
Re: Patch to fix non-sun targets pretending to be sun-solaris2
- From: "Zack Weinberg" <zack at codesourcery dot com>
- To: "Kaveh R. Ghazi" <ghazi at caip dot rutgers dot edu>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Fri, 28 Nov 2003 11:29:04 -0800
- Subject: Re: Patch to fix non-sun targets pretending to be sun-solaris2
- References: <200311201640.hAKGeWVq000042@caip.rutgers.edu>
"Kaveh R. Ghazi" <firstname.lastname@example.org> writes:
> As discussed previously,
> several platforms are reusing config/sol2.h and this causes them to
> erroneously define `sun' and misidentify themselves. This causes
> problems in user code when one checks "#ifdef sun" and makes any
> assumptions based on that.
> Perhaps the 'real' fix is to separate out the common elements of
> sol2.h into yet another file, then disentangle the entire mess. I
> felt that was too invasive for 3.4 in stage3, but I still think we
> should fix the macro problem. The solution I propose is to undefine
> sun in the right places. These are easier to identify and edit rather
> than pulling apart the config stuff.
This is probably what we'll have to do for 3.4 but I would like to see
what your 'real' fix would look like, before making a decision. If
nothing else, that can then be put on tree-ssa in anticipation of 3.5.