This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [tree-ssa][PATCH]: Fix building of dominator tree


On Tue, 2003-11-25 at 16:27, Daniel Berlin wrote:
> 
> On Nov 26, 2003, at 4:03 PM, Jason Merrill wrote:
> 
> > On Mon, 24 Nov 2003 14:39:31 -0500, Daniel Berlin 
> > <dberlin@dberlin.org> wrote:
> >
> >> As discussed in private mail, we need to clear dom_children on the
> >> ENTRY_BLOCK as well, which means using FOR_ALL_BB instead of 
> >> FOR_EACH_BB.
> >
> > Ack!  Surely we can name these macros to make this distinction clear.
> > Perhaps FOR_ALL_BB and FOR_ALL_REAL_BB?
> 
> Sure.
> I was saving that till we decided on a good name, since it's gonna 
> affect a lot of files if we rename FOR_EACH_BB (which only does real 
> bb's)
> 
I'd be tempted to leave FOR_EACH_BB. We've all used it and know what it
is. I wasn't even aware there was another option, so I'd prefer to see
FOR_ALL_BB changed to something more verbose and descriptive...

FOR_EACH_BB_ENTRY_AND_EXIT  or somesuch thing. That seems clear to me
:-)


Andrew



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]