This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Speed up genattrtab


Hello,

> ...
> > + 	  newexp = mk_attr_alt (1 << atoi (XSTR (exp, 1)));
> 
> I don't see the part of the patch that checks whether this can
> overflow.  In particular, rs6000 has 53 possible insn type attributes,
> and you're using 'int'.

I am only interested in number of alternatives; and if there are so
many of them that they won't fit into int, genattrtab won't work
anyway -- see compute_alternative_mask, insn_alternatives, etc.

> Could you split the second part out into a separate patch?

of course.

Zdenek


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]