This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[tree-ssa] Your patch is causing regressions

So did you actually test this patch?

2003-11-21  Jan Hubicka  <>
        * tree-dfa.c (get_expr_operands): Fix handling of CALL_EXPR.
        * tree-must-alias.c (tree_compute_must_alias): promote pointers.
        (find_addressable_vars):  Deal with complex constant expressions;
        do not clear may_point_to_global_mem.

It's clearly causing regressions on i686-pc-linux-gnu.

  ! FAIL: gcc.c-torture/execute/980701-1.c execution,  -O3 
  ! FAIL: gcc.c-torture/execute/980701-1.c execution,  -O3 -g 

  ! FAIL: 23_containers/vector/cons/ execution test
  ! FAIL: 24_iterators/ execution test

If our policies on testing are not clear enough, if you're going to
contribute changes, they must be bootstrapped and regression tested
on i686-pc-linux-gnu.  I don't want to see a patch submitted for
integration until those tests have completed and passed successfully.

This is the second time in a week we have had to revert one of your
changes from the tree-ssa branch.  I strongly suggest you focus more
effort on getting your patches properly tested.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]