Re: Enable first scheduling pass for SH4

[Sanjiv Kumar Gupta <sanjivg at noida dot hcltech dot com>]

On Wed, 19 Nov 2003 18:20:20 -0500, Vladimir Makarov <vmakarov@redhat.com> 
wrote:

> Sanjiv Kumar Gupta wrote:
> > On Thu, 13 Nov 2003 12:18:11 -0500, Vladimir Makarov 
> > <vmakarov@redhat.com>
> > wrote:
> > > So if you decide not to implement this approach, I would prefer the
> > > previous machine-depnendent approach.  Just let me know and I'll look 
> > at
> > > the previous patch again and probably approve it.
> >
> > Here is the link:
> > http://gcc.gnu.org/ml/gcc-patches/2003-09/msg00090.html
> >
> > I can submit a follow-up patch if you want some changes.
>
> Sanjiv,
>
> I've examined the patch.  In whole, the patch is ok.  But I have some
> minor comments:

Thanks for the review. I have made the changes and added documentation in 
tm.texi for new hooks. I will submit after the test cycle is complete.

> o Shed1 is switched on for SH5 too.  Your hooks work for all
> subtargets but sh4 is not mentioned there.  If the code is
> to work for sh5 too (I am not sure about this.  I think it will
> require additional benchmarking and tuning), you should be more
> accurate in calculation of register pressure for sh5 because
> values of DImode and DFmode can be placed in one register for sh5.
> If it is not the code checking subtarget should be added (which is
> a good practice in any case because new subtargets could be added
> in future).

Enabled sched1 only when target is TARGET_HARD_SH4.

Regards,
--sanjiv.