This is the mail archive of the
mailing list for the GCC project.
Re: RFA: New V3 demangler
- From: DJ Delorie <dj at redhat dot com>
- To: ian at wasabisystems dot com
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Thu, 20 Nov 2003 16:25:00 -0500
- Subject: Re: RFA: New V3 demangler
- References: <firstname.lastname@example.org>
> This file is part of the libiberty library, which is part of GCC.
Er, not quite true. Look up the threads on libiberty "ownership" and
copyright stuff; there has been some debate about libiberty being
"part of" gcc, vs "used by" gcc (and many other projects). It affects
the type of copyright assignment papers we need to let folks edit the
file. We might as well get this one right the first time ;-)
> /* Avoid pulling in the ctype tables for this simple usage. */
> #define IS_DIGIT(c) ((c) >= '0' && (c) <= '9')
The whole point of the tables is to handle encodings where those
digits are not concecutive. I don't know of any, but...
> || (peek_next >= 'A' && peek_next <= 'Z'))
This definitely is wrong. We support EBCDIC. Or at least we're
supposed to; the implementation is incomplete, but no sense making it
worse. Unless you want to talk me into letting it slip for now...