This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [www-patch] bugs.html rewrite,part 6: section about upgrading the compiler


On 18 Nov, Gerald Pfeifer wrote:
> Looks fine, thanks for that work!
> 
> Please find some more detailed comments below. (It's actually much easier
> for me to make such comments than rewrite something from scratch, so I'm
> always happy to get patches from you. ;-) )

You're welcome.
And I really appreciate your comments!

> Gerald
> 
> On Tue, 18 Nov 2003, Volker Reichelt wrote:
>> +++ bugs.html	Tue Nov 18 00:25:06 2003
>> +<p>With each major release (i.e. when the first or second part of the
>> +version number changes) the ABI (application binary interface) usually
>> +changes.  (The ABI defines how the elements of classes are laid out,
>> +how functions are called, how function names are mangled etc.)
> 
> How about:
> 
>  ...the application binary interface (ABI), which defines how..., usually
>  changes.

Well, the sentence would get way too long for my taste (about 4 lines in
the HTML source). I'd rather suggest the following:

+ <h4>ABI changes</h4>
+ 
+ <p>The application binary interface (ABI) defines how the elements of
+ classes are laid out, how functions are called, how function names are
+ mangled etc.  It usually changes with each major release (i.e. when the
+ first or second part of the version number changes).  You <em>must</em>
+ recompile all C++ libraries, or you risk linker errors or crashing
+ programs.  However, the ABI is not changed with bug-fix releases (i.e.
+ when the third part of the version number changes).  The code should be
+ binary compatible among these versions.</p>

Or keep it like this:

+ <h4>ABI changes</h4>
+ 
+ <p>With each major release (i.e. when the first or second part of the
+ version number changes) the application binary interface (ABI) usually
+ changes.  (The ABI defines how the elements of classes are laid out,
+ how functions are called, how function names are mangled etc.)  You
+ <em>must</em> recompile all C++ libraries, or you risk linker errors
+ or crashing programs.  However, the ABI is not changed with bug-fix
+ releases (i.e. when the third part of the version number changes).
+ The code should be binary compatible among these versions.</p>

What do you think?

Btw, shouldn't we rather write "risk linker errors or malfunctioning/crashing
programs" instead of just "... crashing programs"?

> (In any case, please make the change to exchange the full and TLA versions
> of ABI.)

Yup. This also holds for the rest of your remarks which don't need
quoting here.

I found another glitch in the patch: I forgot to update the heading
for the new section in the table of contents. This will be fixed in the
final version.

Regards,
Volker



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]