This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH/Ada: Fix DIR_SEPARATOR bug on win32 targets
- From: Danny Smith <danny_r_smith_2001 at yahoo dot co dot nz>
- To: Arnaud Charlet <charlet at ACT-Europe dot FR>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Fri, 14 Nov 2003 12:22:27 +1100 (EST)
- Subject: Re: PATCH/Ada: Fix DIR_SEPARATOR bug on win32 targets
--- Arnaud Charlet <charlet@ACT-Europe.FR> wrote: > > I think the problem is that Ada also needs
its own version of IS_DIRECTORY_SEPARATOR.
> > The problem with generating the support file was with gnatchop. This
> > quick hack fixes that problem:
>
> I don't see how your patch fixes anything, since the line below the one you've
> modified already references Directory_Separator which should be '\'
No it shouldn't. DIR_SEPARATOR on mingw32 is '/'
DIR_SEPARATOR2 = '\\'
as per defaults in system.h
2003-07-02 Zack Weinberg <zack@codesourcery.com>
* system.h: Include filenames.h.
(IS_DIR_SEPARATOR, IS_ABSOLUTE_PATHNAME): Don't define.
(DIR_SEPARATOR, DIR_SEPARATOR_2): If not already defined,
define based on HAVE_DOS_BASED_FILE_SYSTEM.
* config/i386/xm-cygwin.h, config/i386/xm-djgpp.h
* config/i386/xm-mingw32.h: Don't define
HAVE_DOS_BASED_FILE_SYSTEM,
DIR_SEPARATOR, or DIR_SEPARATOR_2.
* doc/hostconfig.texi: Update to match.
>
> Actually if you need this patch, it most likely means that your patch
> broke gnatchop and other tools, and that GNAT.OS_Lib.Directory_Separator
> is no longer '\'
>
If GNAT.OS_Lib.Directory_Separator is based on system.h DIR_SEPARATOR
it hasn't been '\\' for awhile.
> As for the gnatmake failure, it could also be related to your change.
>
> In other words, not OK for your patch until these errors are understood.
>
Yes I understand that. But I cannot build gnatlib without that patch (since
your patch of 11 Nov.)
Danny
> Arno
http://personals.yahoo.com.au - Yahoo! Personals
New people, new possibilities. FREE for a limited time.