This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: XFAIL for GCC compat testsuite


On Thu, Nov 13, 2003 at 12:20:08PM +0100, Eric Botcazou wrote:
> Hi Janis,
> 
> I've added the possibility to XFAIL your compat testcases on compilation in 
> my tree (for the SPARC port), using the new dg-xfail-if infrastructure.
> 
> Tested on i586-redhat-linux-gnu, sparc64-sun-solaris2.9 and 
> sparc-sun-solaris2.8. Ok for mainline?
> 
> 
> 2003-11-13  Eric Botcazou  <ebotcazou@libertysurf.fr>
> 
> 	* lib/compat.exp (compat-obj): New xfaildata parameter.
> 	Use it to set compiler_conditional_xfail_data before compiling.
> 	(compat-get-options): Handle dg-xfail-if.
> 	(compat-execute): Retrieve XFAIL data and pass them to compat-obj.
> 	* gcc.dg/compat/vector-1_x.c: XFAIL on SPARC.
> 	* gcc.dg/compat/vector-1_y.c: Likewise.
> 	* gcc.dg/compat/vector-2_x.c: Likewise.
> 	* gcc.dg/compat/vector-2_y.c: Likewise.

As the author of the original code this looks good to me, but I'm not
a maintainer and can't approve it.

To whichever maintainer looks at this, please also take a look at the
fix in http://gcc.gnu.org/ml/gcc-patches/2003-10/msg01114.html from
David Ung; there was a discussion just before this about how no test
case change could be considered obvious, otherwise I would have checked
it in.

Janis


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]