This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Java] PATCH for optimization/12547


On Wed, 12 Nov 2003, Jason Merrill wrote:
> This bug on the tree-ssa branch turned out to be an unsharing problem.
> jsturm had removed java_tree_inlining_walk_subtrees as part of his work on
> Java gimplification; as a result, the unsharing pass wasn't walking into
> BLOCKs, so it wasn't really doing any unsharing of Java code.  The affected
> testcases have shared COND_EXPRs.

Thanks Jason.  Sorry for the breakage.  I don't remember why I removed
that but I'm sure I had at least a couple of misunderstandings back then:

a) inlining is performed on GENERIC trees, not always GIMPLE.
b) java_tree_inlining_walk_subtrees is used outside of the inliner, in
spite of its name.

walk_tree really ought to come out of tree-inline.c, and Java BLOCK nodes
simply need to die.

Jeff


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]