This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: RFA reload.c patch


On Wed, 2003-11-12 at 15:26, Eric Christopher wrote:
> +		      && (LEGITIMATE_CONSTANT_P (x)
> +			  || PREFERRED_RELOAD_CLASS (x, class) != NO_REGS))

> +			     && (LEGITIMATE_CONSTANT_P (x)
> +				 || PREFERRED_RELOAD_CLASS(x, class) != NO_REGS))))

Those should be && operators not || operators, as both conditions must
be true.  That also allows you to get rid of some parentheses now.

In the second test, the x should be XEXP (XEXP (x, 0), 1), i.e. the same
test used in CONSTANT_P.

Otherwise, yes, I believe this is the right fix.
-- 
Jim Wilson, GNU Tools Support, http://www.SpecifixInc.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]