This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Patch for Bug#12955
Eric Christopher wrote:
>
> On Sat, 2003-11-08 at 01:01, Eric Christopher wrote:
> > #if 0 is never the right way to fix this. If the code is wrong then just
> > delete and replace.
>
> I've realized that this may have sounded harsh. That wasn't my intention
> at all, I was just commenting for a formatting change.
>
> If it sounded harsh to you, I apologize.
No, it was fine. Generally, I agree with you.
In two places I added #if 0's which surround code which tests for
ROUND_TOWARDS_ZERO. There are no targets which implement this option, so
it isn't easy to check if the code is correct or not. I'm pretty sure
that the low-order bit proxy which I added is not compatible with it
for the non-ROUND_TOWARDS_ZERO case. I left the code in simply in
case it may be needed if ROUND_TOWARDS_ZERO is ever used.
There is code in pack_d() which also handles ROUND_TOWARDS_ZERO. It
looks like this correctly, but without tests it's hard to confirm that
the excluded code is not needed.
There was a pre-existing #if 0 in _fpmul_parts() which excludes code
which attempts to do rounding. This does appear to be unnecessary.
--
Michael Eager eager@mvista.com 408-328-8426
MontaVista Software, Inc. 1237 E. Arques Ave., Sunnyvale, CA 94085