This is the mail archive of the
mailing list for the GCC project.
Re: [PATCH] fix compiling gcc in SPEC CPU 2000 on darwin with -finline-functions and -funit-at-a-time
- From: Fariborz Jahanian <fjahanian at apple dot com>
- To: Geoffrey Keating <geoffk at apple dot com>
- Cc: Andrew Pinski <pinskia at physics dot uc dot edu>, gcc-patches at gcc dot gnu dot org
- Date: Thu, 6 Nov 2003 12:16:35 -0800
- Subject: Re: [PATCH] fix compiling gcc in SPEC CPU 2000 on darwin with -finline-functions and -funit-at-a-time
On Thursday, November 6, 2003, at 10:15 AM, Geoffrey Keating wrote:
On Thursday, November 6, 2003, at 10:14 AM, Fariborz Jahanian wrote:
This patch is not right. It eliminates the symptom of the bug by
inserting an extra label. Bug is in the middle-end. In this
special case, function called in the inlined version of of LIST() has
its 'static' flag set. I am looking at this bug now.
You mean, TREE_PUBLIC is not set?
It would be correct to have DECL_STATIC set, since the function does
have static storage duration.
I was referring to TREE_STATIC. In the 3.3 version, TREE_STATIC that I
see for the call is 0 which means
no definition is seen yet. in 3.4 version it is 0 in the first call and
1 in the second call. This is probably
the consequence of change of inlining in 3.4. So, setting might be
correct (investigating to be sure). If so,
then a localized fix to darwin.c is in order.
- thanks, fariborz