This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [tree-ssa] COMPOUND_EXPR removal


> On Wed, Nov 05, 2003 at 05:08:03PM +0100, Zdenek Dvorak wrote:
> > this patch replaces the COMPOUND_EXPRs by the double linked list of
> > containers, thus finally making the manipulation with cfg reasonably
> > simple.
> 
> Unfortunately, it doesn't start early enough.
> 
> In order to fix tree-eh speed problems, the double-linked-list has to
> exist before lower_eh_constructs; i.e. at minimum it needs to be created
> during gimplification.  Doing it there also avoids the need for 
> rationalize_compound_expr during gimplification as well, which is nice.
> 
> But in order to have the double-linked-list exist before all the other
> containers (COND_EXPR, TRY_FINALLY_EXPR, etc) have been removed, we have
> to have a way to embed this list into existing tree nodes.  Which means
> that we need a new tree container.

It would be nice to do this incrementally starting from what we do have
now.

Adding more sanity check to verify_flow_info you notice that the CFG and
SSA graph is plain broken after most of not completelly trivial edge
splits.  This has potential to cause people spend ages debugging their
code (it bit me in pretty obvious way not being able to verify CFG after
expansion, but it manifest in many other weird ways in current tree
too).  Zdenek got edge splitting right that is itself a big win.

Accepting Zdenek's patch would help me to push out the chain of changes
I have (verify_flow_info checking SSA graph consistency, fixes to few
other places breaking it, patches to get folding of some expressions we
fold only at expansion time, reordering of code expanding nested
functions so we can do so after the body is expanded and hopefully
the CFG transitive expansion still being worked on)

Honza
> 
> 
> r~


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]