This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Question on -Werror usage in Makefiles...


"Kaveh R. Ghazi" <ghazi@caip.rutgers.edu> writes:

>  > From: "Zack Weinberg" <zack@codesourcery.com>
>  > 
>  > Gabriel Dos Reis <gdr@integrable-solutions.net> writes:
>  > 
>  > > "Kaveh R. Ghazi" <ghazi@caip.rutgers.edu> writes:
>  > >
>  > > | +  const DWunion uu = {.ll = u};
>  > > | +  const DWunion w = { {.low = -uu.s.low,
>  > > | +		       .high = -uu.s.high - ((UWtype) w.s.low > 0) } };
>  > >
>  > > I thought these constructs are only C99...
>  > 
>  > Perfectly ok to use C99 constructs in libgcc2.c as long as gcc
>  > properly implements them.
>  > zw
>
> Perfectly ok, as in "ok to install?"

I wasn't expressing an opinion on the code, just the notion.

I agree with Gaby that use of w.s.low in w's initializer is at least a
potential problem.  Why not use uu.s.low there, and adjust the
surrounding expression accordingly?

> I'd also like to hear from Joern whether it solves the "uninitialized"
> warnings.

Yes, let's make sure this does solve the problem at hand.

zw


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]