This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH m68k] Fix TRANSFER_FROM_TRAMPOLINE for -Werror


Bernardo Innocenti <bernie@develer.com> writes:

> Gunther Nikl wrote:
>
>>  {								\
>> -  register char *a0 asm ("%a0");				\
>> +  register char *a0 asm ("%a0") = a0;				\
>
> This is... err... ugly.  Couldn't you use __attribute__((used))
> instead?

Note that TRANSFER_FROM_TRAMPOLINE is actually unused since the rewrite of
the trampoline support on m68k 7 years ago:

<http://gcc.gnu.org/cgi-bin/cvsweb.cgi/old-gcc/config/m68k/m68k.h?rev=1.53&content-type=text/x-cvsweb-markup&cvsroot=gcc>

The definition is only left in for backward compatibility with old object
files, so I'd vote for removing it completely.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, Deutschherrnstr. 15-19, D-90429 Nürnberg
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]