This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Your changes to Ada C files had several problems


> On the one hand, all patches must be thoroughly tested before
> application, and it is legitimate to call people on it if they don't.

Right, what I am asking is to be a little bit more careful, since these
errors could have been avoided.

Also having to update the copyright notices after the fact is both
painful and error prone.

I'd like also to ask people, now that we have an Ada test suite, to
run it (make check-ada) before committing Ada changes: the subtle exception
handling error would have been detected right away.

I can also provide a script that does most of the style/copyright checks
if that can help.

Arno


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]