This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Your changes to Ada C files had several problems
Daniel Berlin <dberlin@dberlin.org> writes:
>> Please wait for an Ada maintainer to OK your patch before making
>> changes in the Ada tree next time, thanks. As you can see, your
>> changes were not as obvious as they looked.
>
> Except that prototype conversions are pre-approved, last i looked, and
> don't require approval from a specific maintainer.
They are.
On the one hand, all patches must be thoroughly tested before
application, and it is legitimate to call people on it if they don't.
On the other hand, this patch had two actual errors in it, both of
them trivial and easily corrected, so Arnaud's response seems
disproportionate to the problem. And I do not see why trailing
whitespace deserves even to be mentioned (unless it broke multiline
macros or something).
zw